[Asterisk-code-review] SWP-8578 stasis: Improve message type (asterisk[15])

[Chris Savinovich]

Chris Savinovich has uploaded this change for review. ( https://gerrit.asterisk.org/9511


Change subject: SWP-8578 stasis: Improve message type
......................................................................

SWP-8578
stasis: Improve message type

Fixes issue where error msg
"Use of before/init after destruction"
was being printed on disabled messages
in dev mode.  With this
fix if message is disabled
a warning will print.

Change-Id: Ie0d866d1cbc60c16dbef08bc65e99505c3c1adfa
---
M main/stasis.c
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/9511/1

diff --git a/main/stasis.c b/main/stasis.c
index 190ab14..c76e7f5 100644
--- a/main/stasis.c
+++ b/main/stasis.c
@@ -1199,7 +1199,12 @@
 void stasis_log_bad_type_access(const char *name)
 {
 #ifdef AST_DEVMODE
-	ast_log(LOG_ERROR, "Use of %s() before init/after destruction\n", name);
+	if (stasis_message_type_declined(name)) {
+		ast_log(LOG_WARNING, "Use of %s() while in declined list\n", name);
+	}
+	else {
+		ast_log(LOG_ERROR, "Use of %s() before init/after destruction\n", name);
+	}
 #endif
 }
 

-- 
To view, visit https://gerrit.asterisk.org/9511
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0d866d1cbc60c16dbef08bc65e99505c3c1adfa
Gerrit-Change-Number: 9511
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180718/6b5f39a0/attachment-0001.html>