[Asterisk-code-review] loader: Fix startup issues. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9446 )

Change subject: loader: Fix startup issues.
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/9446/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/9446/1/main/loader.c@1611
PS1, Line 1611: 		ast_log(LOG_ERROR, "Allocation failure adding module to load priority list.\n");
This is redundant with the allocation error built into ast_calloc()


https://gerrit.asterisk.org/#/c/9446/1/main/loader.c@1617
PS1, Line 1617: 		ast_log(LOG_ERROR, "Allocation failure adding module to load priority list.\n");
This is redundant with the allocation error built into ast_strdup()


https://gerrit.asterisk.org/#/c/9446/1/main/loader.c@1676
PS1, Line 1676: 			res = -1;
Should we be returning -2 here?


https://gerrit.asterisk.org/#/c/9446/1/main/loader.c@1955
PS1, Line 1955: 		AST_LIST_TRAVERSE_SAFE_BEGIN(load_order, order, entry) {
With the new module loader dependency tree, this loop needs to tell the difference between a built-in module and an external module.  Currently it allows the user to noload builtin modules:

noload=CDR Engine


https://gerrit.asterisk.org/#/c/9446/1/main/loader.c@1990
PS1, Line 1990: 	if ((res = loader_builtin_init(&load_order))) {
Assignment in if


https://gerrit.asterisk.org/#/c/9446/1/main/loader.c@1994
PS1, Line 1994: 	if ((res = loader_config_init(&load_order))) {
Assignment in if



-- 
To view, visit https://gerrit.asterisk.org/9446
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4176699133f0e3a823b43f90c3348677e43a5f3
Gerrit-Change-Number: 9446
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 16 Jul 2018 21:48:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180716/61941b90/attachment.html>