[Asterisk-code-review] t38 fast reject: remove dependency on rtpdump (testsuite[master])

[Torrey Searle]

Torrey Searle has uploaded this change for review. ( https://gerrit.asterisk.org/9379


Change subject: t38_fast_reject: remove dependency on rtpdump
......................................................................

t38_fast_reject: remove dependency on rtpdump

removed dependency on rtpdump, added executable permissions to
perl script validating response time

Change-Id: Ia73ef502f72bd75522d4b6656f6070807dbef349
---
M tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.pl
M tests/fax/pjsip/t38_fast_reject/run-test
M tests/fax/pjsip/t38_fast_reject/test-config.yaml
3 files changed, 1 insertion(+), 22 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/79/9379/1

diff --git a/tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.pl b/tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.pl
old mode 100644
new mode 100755
diff --git a/tests/fax/pjsip/t38_fast_reject/run-test b/tests/fax/pjsip/t38_fast_reject/run-test
index 9d86e01..d20b6af 100755
--- a/tests/fax/pjsip/t38_fast_reject/run-test
+++ b/tests/fax/pjsip/t38_fast_reject/run-test
@@ -49,6 +49,7 @@
         'scenario' : 'A_PARTY.xml',
         '-i' : '127.0.0.1',
         '-p' : '5061',
+        '-m' : '1',
         '-s' : e164,
         '-message_file' : sippA_logfile,
         '-error_file' : sippA_errfile,
@@ -62,29 +63,8 @@
     test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)
     test.reactor_timeout = 100;
 
-    dump_A = WORKING_DIR + "/carrier_rtp.log"
-    dump_B = WORKING_DIR + "/customer_rtp.log"
-    rtpdump_A = subprocess.Popen(["rtpdump", "-t","5", "-F","ascii","-d","101","-o",dump_A, "127.0.0.1/9000"])
-    rtpdump_B = subprocess.Popen(["rtpdump", "-t","5", "-F","ascii","-d","101","-o",dump_B, "127.0.0.1/8000"])
-
-    time.sleep(10) #Wait 10 seconds to ensure that all the sockets are open before running the test	
-
     reactor.run()
 
-    # Kill the RTPDUMP, pass it the signal"
-    rtpdump_A.send_signal(signal.SIGINT)	
-    rtpdump_A.wait()
-    rtpdump_B.send_signal(signal.SIGINT)	
-    rtpdump_B.wait()
-
-    #Verify that audio packets were routed in both directions after G711 fallback
-    if (os.path.getsize(dump_B) == 0):
-    	logger.error("No RTP routed towards customer ...failing the test")
-	return 1
-    if (os.path.getsize(dump_A) == 0):
-    	logger.error("No RTP routed towards carrier ...failing the test")
-	return 1
-
     if not test.passed:
         return 1
 
diff --git a/tests/fax/pjsip/t38_fast_reject/test-config.yaml b/tests/fax/pjsip/t38_fast_reject/test-config.yaml
index cf74af8..90eddc0 100644
--- a/tests/fax/pjsip/t38_fast_reject/test-config.yaml
+++ b/tests/fax/pjsip/t38_fast_reject/test-config.yaml
@@ -7,7 +7,6 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - app    : 'rtpdump'
 
     tags:
         - PJSIP

-- 
To view, visit https://gerrit.asterisk.org/9379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia73ef502f72bd75522d4b6656f6070807dbef349
Gerrit-Change-Number: 9379
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180711/ec42b0e5/attachment.html>