[Asterisk-code-review] res parking: Add dialplan functions for lot state and channel (asterisk[master])

[Joshua Elson]

Joshua Elson has posted comments on this change. ( https://gerrit.asterisk.org/9375 )

Change subject: res_parking: Add dialplan functions for lot state and channel
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> What's the difference between
> ${EXTENSION_STATE(${parking_lot}@${parking_space})} = INUSE
> and
> ${PARK_OCCUPIED(${parking_space},${parking_lot})}
> ?

I think the difference there is that EXTENSION_STATE would require that the parking lot extension be hinted. I don't know that's guaranteed to be the case all the time. Might be some other odd state considerations there I'd have to think through, but this at least seemed to keep it fairly clean for us.

Would you guys prefer removing PARK_OCCUPIED in favor of relying on EXTENSION_STATE?


-- 
To view, visit https://gerrit.asterisk.org/9375
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idba6ae55b8a53f734238cb3d995cedb95c0e7b74
Gerrit-Change-Number: 9375
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Elson <joshelson at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Elson <joshelson at gmail.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 17:18:26 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180709/999d236a/attachment.html>