[Asterisk-code-review] res pjsip sdp rtp: include ice in ANSWER only if offered (asterisk[13])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/9376 )

Change subject: res_pjsip_sdp_rtp: include ice in ANSWER only if offered
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/9376/1/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/9376/1/res/res_pjsip_sdp_rtp.c@585
PS1, Line 585: 				   const struct pjmedia_sdp_session *remote, const struct pjmedia_sdp_media *remote_stream)
Does the sdp session struct "remote" need to be passed in here? It doesn't appear to be used.


https://gerrit.asterisk.org/#/c/9376/1/res/res_pjsip_sdp_rtp.c@608
PS1, Line 608: 
Extra blank lines, not a big deal, just nit picking :)



-- 
To view, visit https://gerrit.asterisk.org/9376
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2597ee48e9a287e07aa4030bfa705430a13a92
Gerrit-Change-Number: 9376
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180709/25d6f298/attachment-0001.html>