[Asterisk-code-review] res pjsip session: sdp group:BUNDLE attribute being truncated (asterisk[15])

Kevin Harwell asteriskteam at digium.com
Fri Jul 6 15:40:37 CDT 2018


Hello Jenkins2, Sean Bright, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9373

to look at the new patch set (#2).

Change subject: res_pjsip_session: sdp group:BUNDLE attribute being truncated
......................................................................

res_pjsip_session: sdp group:BUNDLE attribute being truncated

When setting/appending the media id's to the bundle group attribute a '-1' was
being passed to the 'ast_str_set/append' function for the 'max_len' parameter.
This essentially capped the length of the string to what it was originally
allocated with. In this case 64 bytes.

This patch makes it so a '0' is passed as in for the 'max_len', which means
"no maximum length".

ASTERISK-27955 #close

Change-Id: Iec565df6600401d54a502854a53d19bb4cc34876
---
M res/res_pjsip_session.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/73/9373/2
-- 
To view, visit https://gerrit.asterisk.org/9373
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec565df6600401d54a502854a53d19bb4cc34876
Gerrit-Change-Number: 9373
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180706/27075bfd/attachment.html>


More information about the asterisk-code-review mailing list