[Asterisk-code-review] pjproject bundled: Repair ./configure --with-ssl=PATH. (asterisk[13])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/9064 )

Change subject: pjproject_bundled: Repair ./configure --with-ssl=PATH.
......................................................................


Patch Set 1:

> > This snippet should be replaced by what's in configure.ac not
 > configure.
 > 
 > I do not understand. Please, be more concrete which snippet you
 > mean. This is the very best I can do. configure.ac does not do this
 > PATH check. It comes automatically with autotools. The first place
 > where configure.ac is using this, is via AST_EXT_LIB_SETUP – which
 > is executed much later. Therefore, I had to extract the result from
 > the final configure script to match the functionality 1:1 of that
 > what configure.ac creates. At least that was my conclusion. If you
 > came to a different conclusion, please, tell me which snippet to
 > use.
 > 
 > When AST_EXT_LIB_SETUP changes, we have a problem, yes. If you have
 > a better idea to tackle that, please say so.

Hey George,

Not sure if I quite get your response either.  Mind clarifying your thoughts a bit?

Thanks,
Matt


-- 
To view, visit https://gerrit.asterisk.org/9064
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea545aec854dd0e2c061c69bb118a76ce56c5dc6
Gerrit-Change-Number: 9064
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:15:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180706/f43abe6a/attachment.html>