[Asterisk-code-review] res rtp asterisk: Add support for sending NACK requests. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/9225 )

Change subject: res_rtp_asterisk: Add support for sending NACK requests.
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/9225/4/main/data_buffer.c
File main/data_buffer.c:

https://gerrit.asterisk.org/#/c/9225/4/main/data_buffer.c@297
PS4, Line 297: 			if (buffer->cache_count < CACHED_PAYLOAD_MAX
> Since it looks like you're doing the cache population with the same code twice (both in ast_data_buf […]
Bump?


https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c@4402
PS4, Line 4402: 	if (res == 0 || res == 1) {
> Let me read back over this and get back to you so I don't say something silly here that you've alrea […]
I didn't see any callers of this function that separately handled both return values (but maybe I missed something).  In any case, it's not a bit deal and we can keep it as is.



-- 
To view, visit https://gerrit.asterisk.org/9225
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d
Gerrit-Change-Number: 9225
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Thu, 05 Jul 2018 14:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180705/164db6fa/attachment.html>