[Asterisk-code-review] pjsip: Clarify certificate configuration for Websocket. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9327 )

Change subject: pjsip: Clarify certificate configuration for Websocket.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Can you update the XML as well? That way the info shows up when you do an "config show help res_pjsip transport".

https://gerrit.asterisk.org/#/c/9327/1/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/9327/1/configs/samples/pjsip.conf.sample@848
PS1, Line 848: ;
Can you move this note down to the TLS specific parameters (and maybe group them together)?
When I read it the first time I thought it applied to the whole transport section, even though it does say TLS.



-- 
To view, visit https://gerrit.asterisk.org/9327
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I187d994d328c3ed274b6754fd4c2a4955bdc6dd9
Gerrit-Change-Number: 9327
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 03 Jul 2018 12:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180703/7f56fc40/attachment.html>