[Asterisk-code-review] res pjsip registrar.c: Fix compiler error. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Wed Jan 31 11:11:54 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8111 )

Change subject: res_pjsip_registrar.c: Fix compiler error.
......................................................................


Patch Set 1: Code-Review+1

We should directly include headers which define symbols that we use, but we include asterisk.h which includes asterisk/compat.h and that includes signal.h (all unconditionally).  So it's odd that this caused an actual failure.


-- 
To view, visit https://gerrit.asterisk.org/8111
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ae3aa4bf8e7386ac29ade78c0f2caed8e674fa
Gerrit-Change-Number: 8111
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 31 Jan 2018 17:11:54 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180131/7fcd848b/attachment.html>


More information about the asterisk-code-review mailing list