[Asterisk-code-review] Fixed null string trailing after AsyncAGIEnd AMI event (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8047 )

Change subject: Fixed null string trailing after AsyncAGIEnd AMI event
......................................................................


Patch Set 3: Code-Review-1

I'm not comfortable with this change because of the consequences and ripples it creates elsewhere. Other code may have been written to expect the ast_json_null.

Since this is for AMI why not change the ast_manager_str_from_json_object function so that if a json_null is provided as the blob nothing is placed into the string?


-- 
To view, visit https://gerrit.asterisk.org/8047
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice58c16361f9d9e8648261c9ed5d6c8245fb0d8f
Gerrit-Change-Number: 8047
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 31 Jan 2018 11:54:07 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180131/aaa79b6e/attachment-0001.html>