[Asterisk-code-review] Sample modules.conf: comment out example load statement. (asterisk[master])

Jenkins2 asteriskteam at digium.com
Tue Jan 30 06:54:33 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8099 )

Change subject: Sample modules.conf: comment out example load statement.
......................................................................

Sample modules.conf: comment out example load statement.

The sample modules.conf explicitly loaded res_musiconhold.so.  This is
redundent as autoload=yes is already set.  It causes warnings if
res_musiconhold.so was not installed and results in an unexpected load
if the admin disables autoload without remembering to remove the
res_musiconhold load statement.

Also remove reference to unknown module pbx_gtkconsole.

Change-Id: Ib01888994d9f1364b14d3c9fb6ff96774a6e580a
---
M configs/samples/modules.conf.sample
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/configs/samples/modules.conf.sample b/configs/samples/modules.conf.sample
index 38e33e1..431a0a8 100644
--- a/configs/samples/modules.conf.sample
+++ b/configs/samples/modules.conf.sample
@@ -29,12 +29,7 @@
 ; If you want you can combine with preload
 ; preload-require = res_odbc.so
 ;
-; If you want, load the GTK console right away.
-;
-noload => pbx_gtkconsole.so
-;load => pbx_gtkconsole.so
-;
-load => res_musiconhold.so
+;load => res_musiconhold.so
 ;
 ; Load one of: chan_oss, alsa, or console (portaudio).
 ; By default, load chan_oss only (automatically).

-- 
To view, visit https://gerrit.asterisk.org/8099
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib01888994d9f1364b14d3c9fb6ff96774a6e580a
Gerrit-Change-Number: 8099
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180130/1230788a/attachment.html>


More information about the asterisk-code-review mailing list