[Asterisk-code-review] editline: Avoid shifting a negative signed value. (asterisk[15])
    Jenkins2 
    asteriskteam at digium.com
       
    Mon Jan 29 10:34:23 CST 2018
    
    
  
Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8069 )
Change subject: editline: Avoid shifting a negative signed value.
......................................................................
editline: Avoid shifting a negative signed value.
clang 4.0 warned about this.
ASTERISK-27630
Change-Id: Ie2725048c661c1792d8b1d498575144350b6e9ba
---
M main/editline/el.h
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit
diff --git a/main/editline/el.h b/main/editline/el.h
index 641081e..386d84c 100644
--- a/main/editline/el.h
+++ b/main/editline/el.h
@@ -55,9 +55,9 @@
 
 #define	EL_BUFSIZ	1024		/* Maximum line size		*/
 
-#define	HANDLE_SIGNALS	1<<0
-#define	NO_TTY		1<<1
-#define	EDIT_DISABLED	1<<2
+#define	HANDLE_SIGNALS	0x01
+#define	NO_TTY		0x02
+#define	EDIT_DISABLED	0x04
 
 typedef int bool_t;			/* True or not			*/
 
-- 
To view, visit https://gerrit.asterisk.org/8069
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2725048c661c1792d8b1d498575144350b6e9ba
Gerrit-Change-Number: 8069
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180129/397756f1/attachment.html>
    
    
More information about the asterisk-code-review
mailing list