[Asterisk-code-review] BuildSystem: Do not warn when bash is not installed. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Jan 29 08:15:40 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8076 )

Change subject: BuildSystem: Do not warn when bash is not installed.
......................................................................


Patch Set 1: Code-Review-1

I'd prefer that we use `ifneq ($(BASH),)` to skip running the command when appropriate (I assume this would solve the problem).  If bash is installed we don't want to suppress errors from the command.


-- 
To view, visit https://gerrit.asterisk.org/8076
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdf268b0b98c3e7d8089ba87cf78136ac1d785b
Gerrit-Change-Number: 8076
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 29 Jan 2018 14:15:40 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180129/1ac1a84a/attachment.html>


More information about the asterisk-code-review mailing list