[Asterisk-code-review] loader: Use ast cli completion add for 'module load' complet... (asterisk[master])

Corey Farrell asteriskteam at digium.com
Sat Jan 27 14:18:20 CST 2018


Hello Jenkins2, Sean Bright, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8050

to look at the new patch set (#4).

Change subject: loader: Use ast_cli_completion_add for 'module load' completion.
......................................................................

loader: Use ast_cli_completion_add for 'module load' completion.

This addresses all performance issues with 'module load' completion.  In
addition to using ast_cli_completion_add we stop using libedit's
filename_completion_function, instead using ast_file_read_dir.  This
ensures all results are produced from a single call to opendir.

Change-Id: I8bf51ffaa7ef1606f3bd1b5bb13f1905d72c6134
---
M include/asterisk/file.h
M main/Makefile
M main/loader.c
3 files changed, 54 insertions(+), 50 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/50/8050/4
-- 
To view, visit https://gerrit.asterisk.org/8050
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bf51ffaa7ef1606f3bd1b5bb13f1905d72c6134
Gerrit-Change-Number: 8050
Gerrit-PatchSet: 4
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180127/4cea8653/attachment.html>


More information about the asterisk-code-review mailing list