[Asterisk-code-review] Add missing OPTIONAL API and ARI dependences. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Jan 22 11:17:35 CST 2018


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8007

to look at the new patch set (#2).

Change subject: Add missing OPTIONAL_API and ARI dependences.
......................................................................

Add missing OPTIONAL_API and ARI dependences.

I've audited all modules that include any header which includes
asterisk/optional_api.h.  All modules which use OPTIONAL_API now declare
those dependencies in AST_MODULE_INFO using requires or optional_modules
as appropriate.

In addition ARI dependency declarations have been reworked.  Instead of
declaring additional required modules in res/ari/resource_*.c we now add
them to an optional array "requiresModules" in api-docs for each module.
This allows the AST_MODULE_INFO dependencies to include those missing
modules.

Change-Id: Ia0c70571f5566784f63605e78e1ceccb4f79c606
---
M apps/app_mixmonitor.c
M apps/app_statsd.c
M bridges/bridge_builtin_features.c
M res/ari/resource_bridges.c
M res/ari/resource_channels.c
M res/ari/resource_device_states.c
M res/ari/resource_events.c
M res/ari/resource_mailboxes.c
M res/ari/resource_playbacks.c
M res/ari/resource_recordings.c
M res/res_ari_bridges.c
M res/res_ari_channels.c
M res/res_ari_device_states.c
M res/res_ari_events.c
M res/res_ari_mailboxes.c
M res/res_ari_playbacks.c
M res/res_ari_recordings.c
M res/res_monitor.c
M res/res_pjsip.c
M res/res_pjsip/config_transport.c
M res/res_pjsip_outbound_registration.c
M res/res_statsd.c
M rest-api-templates/res_ari_resource.c.mustache
M rest-api-templates/swagger_model.py
M rest-api/api-docs/bridges.json
M rest-api/api-docs/channels.json
M rest-api/api-docs/deviceStates.json
M rest-api/api-docs/events.json
M rest-api/api-docs/mailboxes.json
M rest-api/api-docs/playbacks.json
M rest-api/api-docs/recordings.json
M tests/test_utils.c
M tests/test_websocket_client.c
33 files changed, 85 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/07/8007/2
-- 
To view, visit https://gerrit.asterisk.org/8007
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0c70571f5566784f63605e78e1ceccb4f79c606
Gerrit-Change-Number: 8007
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180122/9e50f212/attachment.html>


More information about the asterisk-code-review mailing list