[Asterisk-code-review] bridge native rtp: Improved handling of channel hold/unhold (asterisk[13])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/6892 )

Change subject: bridge_native_rtp: Improved handling of channel hold/unhold
......................................................................


Patch Set 2:

> > Yes chan_sip. Test channels/SIP/sip_hold_direct_media
 > > There are 3 scenarios - media restrict, IP restrict and IP+media
 > > restrict.
 > >
 > > Without patch in scenarios media restrict and ip+media restrict
 > > after hold reINVITE is send, on hold channel receives only one
 > > reINVITE with asterisk IP and sendrecv in SDP.
 > > In scenario IP restrict, channel on hold receives 2 reINVITES,
 > one
 > > with asterisk IP and after that one with IP 0.0.0.0.
 > >
 > > With patch all scenarios are same - only one reINVITE with
 > asterisk
 > > IP and sendrecv in SDP
 > 
 > I talked with Josh on IRC and he thinks that changing the test
 > should be fine, provided that it is done in a backwards compatible
 > way.

Bump.  Were you planning on making the test changes?


-- 
To view, visit https://gerrit.asterisk.org/6892
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I811fcadd40912bf8814560b8b02582357f19ed5a
Gerrit-Change-Number: 6892
Gerrit-PatchSet: 2
Gerrit-Owner: Vitezslav Novy <a1 at vnovy.net>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Vitezslav Novy <a1 at vnovy.net>
Gerrit-Comment-Date: Mon, 22 Jan 2018 15:34:39 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180122/1bf388b7/attachment-0001.html>