[Asterisk-code-review] res pjsip: Add AMI action 'PJSIPShowContacts' (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/7960 )

Change subject: res_pjsip: Add AMI action 'PJSIPShowContacts'
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7960/2/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/#/c/7960/2/res/res_pjsip/pjsip_options.c@1569
PS2, Line 1569: 	if (ast_manager_register_xml("PJSIPShowContacts", EVENT_FLAG_SYSTEM, ami_show_contacts)) {
              : 		return -1;
              : 	}
This needs to be unregistered in ast_res_pjsip_cleanup_options_handling as well.

Additionally if this fails you also need to clean up the environment like is done above if the observer add fails.



-- 
To view, visit https://gerrit.asterisk.org/7960
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2eed42c74bbc725fad26b8b33b1a5b3161950c73
Gerrit-Change-Number: 7960
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 13:22:35 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180122/16aa3a24/attachment.html>