[Asterisk-code-review] install prereq: For PJProject, point users to configure script. (asterisk[13])

Alexander Traud asteriskteam at digium.com
Sat Jan 20 06:43:15 CST 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7835 )

Change subject: install_prereq: For PJProject, point users to configure script.
......................................................................


Patch Set 4:

OK, then I leave that sRTP in. I wait to remove sRTP from package lists until all my changes/updates have passed. Otherwise, I might get merge conflicts all around. Still, I am pretty surprised that none of the supported platforms comes with the very latest (libSRTP 2.1 + OpenSSL). Go figure! Only FreeBSD 10 comes with OpenSSL but 1.5. Only Ubuntu 18.04 LTS comes with 2.1 but no OpenSSL support.

 > update[d] the commit message with why sRTP was being
 > removed and was giving a +1 to the overall patch that you uploaded.

Yeah, I saw that. Here in my world, I am not allowed to give myself a +1, because +1 means somebody *else* is happy with it. You hijacked my change (which is absolutely fine). However, then I give a +1 to your change, because your hijack was OK for me. I – somebody else – was happy with your change. So, in my world, you gave yourself a +1. Again, a cultural thing – not allowed here, where I come from.


-- 
To view, visit https://gerrit.asterisk.org/7835
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf4b562f81f7c05bd24a3805bd46c0beb4ebd44
Gerrit-Change-Number: 7835
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Sat, 20 Jan 2018 12:43:15 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180120/b2146612/attachment.html>


More information about the asterisk-code-review mailing list