[Asterisk-code-review] channels/SIP/ami/sip notify/call id: 3PCC patch for AMI "SIP... (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7705 )

Change subject: channels/SIP/ami/sip_notify/call_id: 3PCC patch for AMI "SIPnotify".
......................................................................


Patch Set 5: Code-Review-1

Am I wrong in thinking this test could be written in yaml using the SIPpTestCase class and EventActionModule passing in the sipp call_id as one of the keyword parameters? For instance see the following test as examples of using those modules:

tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml

If not at the very least the testsuite already has an ami client handler. Instead of using the SIPpTest class use SIPpTestCase class. You can then register to listen for ami message as well as send ami actions. See the following test as an example on how to use the SIPpTestCase with a custom class that listens for ami events and sends ami actions:

tests/bridge/hold_redirect/devstate_check.py
tests/bridge/hold_redirect/test-config.yaml

This would alleviate the need for a custom ami client handler.


-- 
To view, visit https://gerrit.asterisk.org/7705
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1
Gerrit-Change-Number: 7705
Gerrit-PatchSet: 5
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Comment-Date: Thu, 18 Jan 2018 23:58:17 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180118/f97bf23a/attachment.html>