[Asterisk-code-review] res pjsip: Add AMI action 'PJSIPShowContacts' (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7960 )

Change subject: res_pjsip: Add AMI action 'PJSIPShowContacts'
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/7960/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/#/c/7960/1/res/res_pjsip/pjsip_options.c@932
PS1, Line 932: static struct ao2_container *cli_get_contacts(void)
"cli" implies "command line interface". I'd rename this to just get_contacts or get_all_contacts.


https://gerrit.asterisk.org/#/c/7960/1/res/res_pjsip/pjsip_options.c@962
PS1, Line 962: 		return CMP_STOP;
buf is leaked here. It needs to be freed.



-- 
To view, visit https://gerrit.asterisk.org/7960
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2eed42c74bbc725fad26b8b33b1a5b3161950c73
Gerrit-Change-Number: 7960
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 18 Jan 2018 20:52:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180118/40e61637/attachment.html>