[Asterisk-code-review] BuildSystem: Invoke install not in GNU but POSIX style. (asterisk[15])

Jenkins2 asteriskteam at digium.com
Thu Jan 18 10:08:10 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/7998 )

Change subject: BuildSystem: Invoke install not in GNU but POSIX style.
......................................................................

BuildSystem: Invoke install not in GNU but POSIX style.

ASTERISK-27594

Change-Id: Iaaa6a19d2fe031dffcba441d0502a7ea65c93cb3
---
M build_tools/download_externals
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/build_tools/download_externals b/build_tools/download_externals
index efeb6c5..62b128a 100755
--- a/build_tools/download_externals
+++ b/build_tools/download_externals
@@ -214,7 +214,7 @@
 echo "${full_name}: Installing."
 
 if [[ $EUID == 0 ]] ; then
-	install_params="--group=0 --owner=0"
+	install_params="-g 0 -o 0"
 fi
 
 names=$(${XMLSTARLET} sel -t -m "//file" -v "@name" -n ${cache_dir}/${module_dir}/manifest.xml)
@@ -229,7 +229,7 @@
 		mode=0644
 	fi
 
-	${INSTALL} -Dp ${install_params} --mode=${mode} ${source_path} ${install_path}
+	${INSTALL} -Dp ${install_params} -m ${mode} ${source_path} ${install_path}
 
 done
 ${INSTALL} -Dp ${install_params} --mode=0644 ${cache_dir}/${module_dir}/manifest.xml ${DESTDIR}${ASTMODDIR}/${module_name}.manifest.xml

-- 
To view, visit https://gerrit.asterisk.org/7998
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaa6a19d2fe031dffcba441d0502a7ea65c93cb3
Gerrit-Change-Number: 7998
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180118/dca13672/attachment.html>


More information about the asterisk-code-review mailing list