[Asterisk-code-review] res pjsip session: Move implementation to res pjsip.so. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/7925 )

Change subject: res_pjsip_session: Move implementation to res_pjsip.so.
......................................................................


Patch Set 3:

Yes. I think my main thing is that this doesn't fix the problem - we're reducing the chance of it happening. I would rather we investigate alternative approaches first and discount those before we take the blunt approach of moving res_pjsip_session over. I originally mentioned discarding received traffic if we are shutting down, I wonder if that is still a viable approach to helping the problem.


-- 
To view, visit https://gerrit.asterisk.org/7925
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib76e156ec123477943153d903091406620a9c6ab
Gerrit-Change-Number: 7925
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 17 Jan 2018 13:36:33 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180117/b187e264/attachment.html>