[Asterisk-code-review] res pjsip: Split type=identify to IP address and SIP header ... (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue Jan 16 12:52:28 CST 2018


Hello Jenkins2, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7936

to look at the new patch set (#2).

Change subject: res_pjsip: Split type=identify to IP address and SIP header matching priorities
......................................................................

res_pjsip: Split type=identify to IP address and SIP header matching priorities

The type=identify endpoint identification method can match by IP address
and by SIP header.  However, the SIP header matching has limited
usefulness because you cannot specify the SIP header matching priority
relative to the IP address matching.  All the matching happens at the same
priority and the order of evaluating the identify sections is
indeterminate.  e.g., If you had two type=identify sections where one
matches by IP address for endpoint alice and the other matches by SIP
header for endpoint bob then you couldn't predict which endpoint is
matched when a request comes in that matches both.

* Extract the SIP header matching criteria into its own "header" endpoint
identification method so the user can specify the relative priority of the
SIP header and the IP address matching criteria in the global
endpoint_identifier_order option.  The "ip" endpoint identification method
now only matches by IP address.

ASTERISK-27491

Change-Id: I9df142a575b7e1e3471b7cda5d3ea156cef08095
---
M CHANGES
M UPGRADE-15.txt
M UPGRADE.txt
M configs/samples/pjsip.conf.sample
A contrib/ast-db-manage/config/versions/52798ad97bdf_add_pjsip_identify_by_header.py
M include/asterisk/res_pjsip.h
M res/res_pjsip.c
M res/res_pjsip/pjsip_configuration.c
M res/res_pjsip_endpoint_identifier_ip.c
9 files changed, 170 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/36/7936/2
-- 
To view, visit https://gerrit.asterisk.org/7936
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9df142a575b7e1e3471b7cda5d3ea156cef08095
Gerrit-Change-Number: 7936
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180116/bcfea580/attachment.html>


More information about the asterisk-code-review mailing list