[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Sun Jan 14 20:59:45 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/7872/5/res/res_agi.c
File res/res_agi.c:

https://gerrit.asterisk.org/#/c/7872/5/res/res_agi.c@4720
PS5, Line 4720: 	.requires = "res_speech",
> Well, that's a surprising dependency as I've loaded that module without res
I'm guessing if you tried to run any of the speech commands on a version with RTLD_LAZY it would cause Asterisk to crash.



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 5
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 15 Jan 2018 02:59:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180114/beb9c464/attachment.html>


More information about the asterisk-code-review mailing list