[Asterisk-code-review] loader: Process module dependencies. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7873 )

Change subject: loader: Process module dependencies.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/7873/5/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/7873/5/main/loader.c@92
PS5, Line 92: #if defined(OPTIONAL_API)
I'm thinking about this some more, I'm not sure it's needed.  If OPTIONAL_API is not defined then the module dlopen order will be enforced by symbol usage.  This means that .optional_apis can continue to just enforce load order like they do when OPTIONAL_API is defined.

This also means that modules which are optional and do not use symbols could be listed under .optional_apis and not change based on OPTIONAL_API being defined.



-- 
To view, visit https://gerrit.asterisk.org/7873
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9be08d1dd331aceadc1dcba00b804d71360b2fbb
Gerrit-Change-Number: 7873
Gerrit-PatchSet: 5
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Sun, 14 Jan 2018 23:31:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180114/5cd00ebb/attachment.html>