[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/7872/5/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/7872/5/res/res_pjsip.c@5128
PS5, Line 5128: 	.requires = "res_pjproject,res_pjsip_config_wizard",
> Requires config wizard?  I thought that was optional.
Maybe it should move to .optional_apis?  I know that the config wizard needs to be loaded before res_pjsip, but I don't know if it's OK to load res_pjsip if the config wizard isn't being loaded at all.

George?



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 5
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 14 Jan 2018 23:23:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180114/74de36da/attachment.html>