[Asterisk-code-review] pjsip: Rewrite OPTIONS support with new eyes. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/7710 )

Change subject: pjsip: Rewrite OPTIONS support with new eyes.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c@102
PS1, Line 102: 	/*! \brief The names of the AORs feeding this compositor */
             : 	struct ao2_container *aors;
             : 	/*! \brief The number of AORs that are available */
             : 	unsigned int available;
             : 	/*! \brief The name of the endpoint */
> Keeping the total available aor count correct is fragile.
Clarify how you envision this working.


https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c@122
PS1, Line 122: 	/*! \brief The endpoint state compositors we are feeding */
             : 	AST_VECTOR(, struct sip_options_endpoint_state_compositor *) compositors;
> Does it make sense for multiple endpoints to reference the same aor?
This is something that's been supported for awhile. It would simplify things to not have to, but I'd rather not go that far.


https://gerrit.asterisk.org/#/c/7710/1/res/res_pjsip/pjsip_options.c@1557
PS1, Line 1557: static const struct ast_sorcery_observer endpoint_observer_callbacks = {
> The order of observer callbacks between endpoint and aor objects is indeter
The AOR observer won't be invoked for realtime because it's not created/updated so relying on that won't work.



-- 
To view, visit https://gerrit.asterisk.org/7710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a5ebbfca9001dfe933eaeac4d3babd8d2e6f082
Gerrit-Change-Number: 7710
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 14 Jan 2018 20:51:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180114/cc431dac/attachment.html>