[Asterisk-code-review] res config pgsql: Avoid typecasting an int to unsigned char. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Fri Jan 12 07:47:21 CST 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7942 )

Change subject: res_config_pgsql: Avoid typecasting an int to unsigned char.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7942/1/res/res_config_pgsql.c
File res/res_config_pgsql.c:

https://gerrit.asterisk.org/#/c/7942/1/res/res_config_pgsql.c@1299
PS1, Line 1299: 					snprintf(fieldtype, sizeof(fieldtype), "CHAR(%d)",
Since you have made size an unsigned int you need to use %u to avoid a different analyzer's warning.



-- 
To view, visit https://gerrit.asterisk.org/7942
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If41f400a51973c06cdb9b75462e535b616bfe385
Gerrit-Change-Number: 7942
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 13:47:21 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180112/1717ae62/attachment.html>


More information about the asterisk-code-review mailing list