[Asterisk-code-review] BuildSystem: Really do not pass unknown-warning options to t... (asterisk[master])

Alexander Traud asteriskteam at digium.com
Fri Jan 12 03:20:18 CST 2018


Alexander Traud has uploaded this change for review. ( https://gerrit.asterisk.org/7939


Change subject: BuildSystem: Really do not pass unknown-warning options to the compiler.
......................................................................

BuildSystem: Really do not pass unknown-warning options to the compiler.

When an older GCC version is called with a too new warning option, GCC exited
with an error and Asterisk was not built. Therefore, the configure script tests
the installed compiler whether it supports that warning option. If not, Asterisk
does not pass it to the installed compiler. However, some compilers (like clang)
do not exit (error) but give just a warning in such a case. Because the compiler
did not exit, Asterisk passed the unknown-warning option.

ASTERISK-27560

Change-Id: Ia9d148e689c173df4e91699113605dab2de36038
---
M third-party/pjproject/patches/user.mak
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/39/7939/1

diff --git a/third-party/pjproject/patches/user.mak b/third-party/pjproject/patches/user.mak
index dafb259..55f3b73 100644
--- a/third-party/pjproject/patches/user.mak
+++ b/third-party/pjproject/patches/user.mak
@@ -1,4 +1,4 @@
 
-NUBSV := $(shell gcc -Wno-unused-but-set-variable -o /dev/null -xc -c - </dev/null 2>/dev/null && echo -Wno-unused-but-set-variable)
+NUBSV := $(shell cc -Wno-unused-but-set-variable -Werror -o /dev/null -xc -c - </dev/null 2>/dev/null && echo -Wno-unused-but-set-variable)
 
 CFLAGS += -fPIC $(NUBSV) -Wno-unused-variable -Wno-unused-label -Wno-unused-function -Wno-strict-aliasing

-- 
To view, visit https://gerrit.asterisk.org/7939
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9d148e689c173df4e91699113605dab2de36038
Gerrit-Change-Number: 7939
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180112/e4fd1f14/attachment.html>


More information about the asterisk-code-review mailing list