[Asterisk-code-review] vector: Additional string vector definitions. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7871 )

Change subject: vector: Additional string vector definitions.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7871/3/include/asterisk/vector.h
File include/asterisk/vector.h:

https://gerrit.asterisk.org/#/c/7871/3/include/asterisk/vector.h@58
PS3, Line 58: /*!
            :  * \brief Create a string vector by splitting a string.
            :  *
            :  * \param dest Pointer to an initialized vector.
            :  * \param input String buffer to split.
            :  * \param delim String delimeter passed to strsep.
            :  * \param excludes_cmp NULL or a function like strcmp to exclude duplicate strings.
            :  */
            : int ast_vector_string_create(struct ast_vector_string *dest,
            : 	const char *input, const char *delim,
            : 	int (*excludes_cmp)(const char *s1, const char *s2));
> I know I had already +1'd this, but I'm now thinking this might be better r
That actually makes some sense to me as well.  This function does not return allocated or even initialize the vector, it appends.

I'm also updating the '\brief' with s/Create/Append/.



-- 
To view, visit https://gerrit.asterisk.org/7871
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf02a1efeb2baeea11c59c557d39dd1197494d7
Gerrit-Change-Number: 7871
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 00:03:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180111/b5bc06c8/attachment.html>