[Asterisk-code-review] install prereq: For PJProject, point users to configure script. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7835 )

Change subject: install_prereq: For PJProject, point users to configure script.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7835/2/contrib/scripts/install_prereq
File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/#/c/7835/2/contrib/scripts/install_prereq@a168
PS2, Line 168: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
> Why is this being removed? This was more of a fall back if the
 > package could not be installed.
 > 
 > This should either be left in or the commit message needs to be
 > updated with why this is also being removed.

I agree.  Not sure if it's appropriate to remove libsrtp2 from here but if it is I think it's worth putting in a separate commit so it is mentioned by 'git log --oneline'.



-- 
To view, visit https://gerrit.asterisk.org/7835
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf4b562f81f7c05bd24a3805bd46c0beb4ebd44
Gerrit-Change-Number: 7835
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 19:06:13 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180111/30732ce0/attachment.html>