[Asterisk-code-review] pjsip/basic calls/incoming/nominal/unauthed/ident by user on... (testsuite[master])
Jenkins2
asteriskteam at digium.com
Thu Jan 11 12:41:42 CST 2018
Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/7897 )
Change subject: pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only: Remove test.
......................................................................
pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only: Remove test.
The requirement that "ip" must be in the endpoint identify_by list to
allow the type=identify method to identify the endpoint is not necessary.
The "ip" identifier method can match one and only one endpoint. To even
work, the "ip" identifier method configuration must explicitly specify the
identified endpoint. Therefore, why bother configuring the type=identify
identifier in the first place? The requirement only adds the potential
for configuration errors for no benefit. Even worse, those configuration
errors cannot be detected when the configuration loads. The requirement
was introduced with the ASTERISK_27206 patch.
* Remove the testsuite test that checks the requirement. Listing the "ip"
method in the identify_by value is simply documentation.
Change-Id: I16f64fdfa56eb4b819e8ed2cc46b6314ed664a72
---
D tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf
D tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/pjsip.conf
D tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/sipp/playback_with_initial_sdp.xml
D tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/test-config.yaml
M tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/tests.yaml
5 files changed, 0 insertions(+), 170 deletions(-)
Approvals:
Joshua Colp: Looks good to me, but someone else must approve
Kevin Harwell: Looks good to me, approved
Jenkins2: Approved for Submit
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf
deleted file mode 100644
index a52330b..0000000
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf
+++ /dev/null
@@ -1,4 +0,0 @@
-[default]
-exten => playback,1,Answer()
-same => n,Playback(hello-world)
-same => n,Hangup()
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/pjsip.conf b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/pjsip.conf
deleted file mode 100644
index a123c13..0000000
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/pjsip.conf
+++ /dev/null
@@ -1,51 +0,0 @@
-[local-transport-template](!)
-type=transport
-bind=127.0.0.1
-
-[local-transport6-template](!)
-type=transport
-bind=[::1]
-
-[local-transport-udp](local-transport-template)
-protocol=udp
-
-[local-transport-udp6](local-transport6-template)
-protocol=udp
-
-[endpoint-template-ipv4](!)
-type=endpoint
-context=default
-allow=!all,ulaw,alaw
-media_address=127.0.0.1
-identify_by=username
-transport=local-transport-udp
-
-[endpoint-template-ipv6](!)
-type=endpoint
-context=default
-allow=!all,ulaw,alaw
-media_address=[::1]
-identify_by=username
-transport=local-transport-udp6
-
-[alice-ipv4-udp](endpoint-template-ipv4)
-
-[alice-ipv6-udp](endpoint-template-ipv6)
-
-[alice-ipv4-invalid](endpoint-template-ipv4)
-context=does-not-exist
-
-[alice-ipv6-invalid](endpoint-template-ipv6)
-context=does-not-exist
-
-[identify-template](!)
-type=identify
-
-[alice-identify-ipv4](identify-template)
-endpoint=alice-ipv4-invalid
-match=127.0.0.1
-
-[alice-identify-ipv6](identify-template)
-endpoint=alice-ipv6-invalid
-match=[::1]
-
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/sipp/playback_with_initial_sdp.xml b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/sipp/playback_with_initial_sdp.xml
deleted file mode 100644
index 790992f..0000000
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/sipp/playback_with_initial_sdp.xml
+++ /dev/null
@@ -1,81 +0,0 @@
-<?xml version="1.0" encoding="ISO-8859-1" ?>
-<!DOCTYPE scenario SYSTEM "sipp.dtd">
-
-<scenario name="INVITE to playback with SDP in initial INVITE">
- <send retrans="500">
- <![CDATA[
-
- INVITE sip:playback@[remote_ip]:[remote_port] SIP/2.0
- Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
- From: test1 <sip:[service]@[local_ip]:[local_port]>;tag=[call_number]
- To: test <sip:test@[remote_ip]:[remote_port]>
- Call-ID: [call_id]
- CSeq: 1 INVITE
- Contact: <sip:test@[local_ip]:[local_port];transport=[transport]>
- Max-Forwards: 70
- Subject: Test
- User-Agent: Test
- Content-Type: application/sdp
- Content-Length: [len]
-
- v=0
- o=phoneA 53655765 2353687637 IN IP[local_ip_type] [local_ip]
- s=-
- c=IN IP[media_ip_type] [media_ip]
- t=0 0
- m=audio 6000 RTP/AVP 0
- a=rtpmap:0 PCMU/8000
-
- ]]>
- </send>
-
- <recv response="100"
- optional="true">
- </recv>
-
- <recv response="200" rtd="true">
- </recv>
-
- <send>
- <![CDATA[
-
- ACK sip:playback@[remote_ip]:[remote_port] SIP/2.0
- Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
- From: test1 <sip:[service]@[local_ip]:[local_port]>;tag=[call_number]
- To: test <sip:test@[remote_ip]:[remote_port]>[peer_tag_param]
- Call-ID: [call_id]
- CSeq: 1 ACK
- Contact: <sip:test@[local_ip]:[local_port];transport=[transport]>
- Max-Forwards: 70
- Subject: Test
- Content-Length: 0
-
- ]]>
- </send>
-
- <recv request="BYE">
- </recv>
-
- <send>
- <![CDATA[
-
- SIP/2.0 200 OK
- [last_Via:]
- [last_From:]
- [last_To:]
- [last_Call-ID:]
- [last_CSeq:]
- Contact: <sip:[local_ip]:[local_port];transport=[transport]>
- Content-Length: 0
-
- ]]>
- </send>
-
- <!-- definition of the response time repartition table (unit is ms) -->
- <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
-
- <!-- definition of the call length repartition table (unit is ms) -->
- <CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/>
-
-</scenario>
-
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/test-config.yaml b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/test-config.yaml
deleted file mode 100644
index 7b9e7b5..0000000
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/test-config.yaml
+++ /dev/null
@@ -1,33 +0,0 @@
-testinfo:
- summary: 'Tests incoming calls without authentication matching only based on user'
- description: |
- 'Run a SIPp scenario that sends various calls to res_pjsip, which should be matched using username only'
-
-test-modules:
- test-object:
- config-section: test-object-config
- typename: 'sipp.SIPpTestCase'
-
-test-object-config:
- fail-on-any: False
- test-iterations:
- -
- scenarios:
- # IPv4 & UDP
- - { 'key-args': {'scenario': 'playback_with_initial_sdp.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice-ipv4-udp'} }
- # IPv6 & UDP
- -
- scenarios:
- - { 'target': '[::1]', 'key-args': {'scenario': 'playback_with_initial_sdp.xml', '-i': '[::1]', '-p': '5061', '-s': 'alice-ipv6-udp'} }
-
-properties:
- minversion: [ '13.19.0', '15.2.0' ]
- dependencies:
- - sipp :
- version : 'v3.0'
- - asterisk : 'app_dial'
- - asterisk : 'app_echo'
- - asterisk : 'app_playback'
- - asterisk : 'res_pjsip'
- tags:
- - pjsip
diff --git a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/tests.yaml b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/tests.yaml
index 722964b..68e17f6 100644
--- a/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/tests.yaml
+++ b/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/tests.yaml
@@ -2,6 +2,5 @@
- test: 'ident_by_host'
- test: 'ident_by_host_only'
- test: 'ident_by_user'
- - test: 'ident_by_user_only'
- test: 'ident_by_user_drop_options'
- test: 'ident_by_header'
--
To view, visit https://gerrit.asterisk.org/7897
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16f64fdfa56eb4b819e8ed2cc46b6314ed664a72
Gerrit-Change-Number: 7897
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180111/6ed02ebb/attachment-0001.html>
More information about the asterisk-code-review
mailing list