[Asterisk-code-review] res pjsip session: Move implementation to res pjsip.so. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7925 )

Change subject: res_pjsip_session: Move implementation to res_pjsip.so.
......................................................................


Patch Set 2:

This is mostly a direct move of code.  Within the code which was moved:
* Calls to ast_sip_register_service / ast_sip_unregister_service have been replaced with internal versions.
* Calls to ast_module_ref / ast_module_unref have been replaced by internal_res_pjsip_ref / internal_res_pjsip_unref.

Please do not give -1 on this review unless it introduces a new bug/issue.  Any issues with existing code that was moved should be fixed separately instead of being hidden in this move.

res_pjsip.c contains the change which is most important to review.  I'm not sure the call to pjsip_session_unload() is in the "best" spot, or maybe pjsip_session_unload needs to be split into two functions (one to unregister pjproject stuff, another to release the asterisk containers).


-- 
To view, visit https://gerrit.asterisk.org/7925
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib76e156ec123477943153d903091406620a9c6ab
Gerrit-Change-Number: 7925
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 22:00:10 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180110/f0f32024/attachment.html>