[Asterisk-code-review] res pjsip session: Always bundle streams if WebRTC is enabled. (asterisk[master])

[Jenkins2]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/7884 )

Change subject: res_pjsip_session: Always bundle streams if WebRTC is enabled.
......................................................................

res_pjsip_session: Always bundle streams if WebRTC is enabled.

Some WebRTC clients can't handle renegotiation with the addition of
streams that include an offer to bundle. They instead expect the
newly added streams to already be bundled. This change does such a thing
if WebRTC support is enabled on an endpoint.

ASTERISK-27566

Change-Id: I7fe9b7ac35a2798627d9c2c8369129f407af6461
---
M res/res_pjsip_session.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Matthew Fredrickson: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index c339382..53f60cc 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -456,6 +456,12 @@
 				return NULL;
 			}
 			session_media->bundle_group = 0;
+
+			/* Some WebRTC clients can't handle an offer to bundle media streams. Instead they expect them to
+			 * already be bundled. Every client handles this scenario though so if WebRTC is enabled just go
+			 * ahead and treat the streams as having already been bundled.
+			 */
+			session_media->bundled = session->endpoint->media.webrtc;
 		} else {
 			session_media->bundle_group = -1;
 		}

-- 
To view, visit https://gerrit.asterisk.org/7884
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fe9b7ac35a2798627d9c2c8369129f407af6461
Gerrit-Change-Number: 7884
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180109/207bfbcf/attachment.html>