[Asterisk-code-review] res pjsip endpoint identifier ip.c: Allow multiple IdentifyD... (asterisk[13])

George Joseph asteriskteam at digium.com
Tue Jan 9 07:39:41 CST 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7847 )

Change subject: res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7847/1/res/res_pjsip_endpoint_identifier_ip.c
File res/res_pjsip_endpoint_identifier_ip.c:

https://gerrit.asterisk.org/#/c/7847/1/res/res_pjsip_endpoint_identifier_ip.c@496
PS1, Line 496: 	identifies = ast_sorcery_retrieve_by_fields(ast_sip_get_sorcery(), "identify",
             : 		AST_RETRIEVE_FLAG_MULTIPLE | AST_RETRIEVE_FLAG_ALL, NULL);
If you set fields to ("endpoint", endpoint_id) you save having to retrieve all identifies from the database.



-- 
To view, visit https://gerrit.asterisk.org/7847
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie146792aef72d78e05416ab5b27bc552a30399db
Gerrit-Change-Number: 7847
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 09 Jan 2018 13:39:41 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180109/199c12c7/attachment.html>


More information about the asterisk-code-review mailing list