[Asterisk-code-review] res stasis: Reduce RAII VAR usage. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Jan 8 17:51:09 CST 2018


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7831

to look at the new patch set (#5).

Change subject: res_stasis: Reduce RAII_VAR usage.
......................................................................

res_stasis: Reduce RAII_VAR usage.

In addition to being a micro-optimization (RAII_VAR has overhead), this
change improves output of REF_DEBUG.  Unfortunately when RAII_VAR calls
ao2_cleanup it does so from a generated _dtor_varname function.  For
example this caused _dtor_app to release a reference instead of
__stasis_app_unregister.

Change-Id: I4ce67120583a446babf9adeec678b71d37fcd9e5
---
M res/res_stasis.c
M res/stasis/app.c
M res/stasis/command.c
M res/stasis/control.c
M res/stasis/stasis_bridge.c
5 files changed, 323 insertions(+), 172 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/31/7831/5
-- 
To view, visit https://gerrit.asterisk.org/7831
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ce67120583a446babf9adeec678b71d37fcd9e5
Gerrit-Change-Number: 7831
Gerrit-PatchSet: 5
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180108/21b91719/attachment.html>


More information about the asterisk-code-review mailing list