[Asterisk-code-review] loader: Process module dependencies. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7873 )

Change subject: loader: Process module dependencies.
......................................................................


Patch Set 1:

This commit is mostly functional.  Some modules could be missing dependencies (if I can't built them).  That could mean those modules might be loaded in the incorrect order, though this would also indicate the load_pri of those modules is wrong.

I have not run the testsuite on this.  Most of my testing has involved debugging the order of calls to ast_module_info->load.  Some modules of equal priority may load in a different order, but the order between such modules is undefined anyways.  I've also verified that basic startup + shutdown of Asterisk does not produce REF_DEBUG leaks, so all modules are able to unload (no circular references).

At last check this did not cause any modules to load before modules of lower priority.  Initially a couple modules were loaded out of "load_pri" order, in both cases the load_pri was incorrect and has already been fixed in all branches.


-- 
To view, visit https://gerrit.asterisk.org/7873
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9be08d1dd331aceadc1dcba00b804d71360b2fbb
Gerrit-Change-Number: 7873
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 08 Jan 2018 22:34:21 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180108/6f7872a1/attachment-0001.html>