[Asterisk-code-review] res pjsip: Add AMI action 'PJSIPShowAuths' (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7808 )

Change subject: res_pjsip: Add AMI action 'PJSIPShowAuths'
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

A mention in the Asterisk 15 to 16 CHANGES file section is needed.

https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip.c@2313
PS1, Line 2313: 	<managerEvent language="en_US" name="AuthList">
This event is redundant with the AuthDetail event.


https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip.c@2530
PS1, Line 2530: 	<manager name="PJSIPShowAuths" language="en_US">
The AuthList event is the same as the AuthDetail event.  The EndpointName header is optional to that event.  See res/res_pjsip/config_auth.c:format_ami_auth_handler()


https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip.c@2536
PS1, Line 2536: 			<para>
              : 			Provides a listing of all Auths. For each Auth an <literal>AuthList</literal> event
There shouldn't be a line break immediately after the <para> because the CLI help inserts a space for line wrapping.  See the CLI "manager show command PJSIPShowAuths" output for this paragraph.

<para>Provides a listing..


https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip/config_auth.c
File res/res_pjsip/config_auth.c:

https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip/config_auth.c@208
PS1, Line 208: static int format_ami_authlist_handler(void *obj, void *arg, int flags)
The AuthList event is the same as the AuthDetail event.  The EndpointName header is optional to that event.

Thus this function's contents should be:
{
  return format_ami_auth_handler(obj, arg, flags) ? CMP_STOP : 0;
}


https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip/config_auth.c@216
PS1, Line 216: 		return -1;
This is an ao2_callback traversal matching function.  This should be CMP_STOP to abort the container traversal.


https://gerrit.asterisk.org/#/c/7808/1/res/res_pjsip/config_auth.c@246
PS1, Line 246: 	astman_send_listack(s, m, "A listing of Auths follows, presented as AuthList events",
s/AuthList/AuthDetail/



-- 
To view, visit https://gerrit.asterisk.org/7808
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a88a75b38a2b1dd9d1de6c0307b20a3f584c817
Gerrit-Change-Number: 7808
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 07 Jan 2018 04:14:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180106/06ffe798/attachment.html>