[Asterisk-code-review] General: Silence modules on (un)load. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7830 )

Change subject: General: Silence modules on (un)load.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/7830/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/7830/2//COMMIT_MSG@14
PS2, Line 14: ASTERISK-27475, the former talkative module 'res_curl' is built as side-effect.
s/ASTERISK-27475/ASTERISK_27475/

The gerrit or JIRA plugin is indiscriminate about issue references.  It will attempt to close any issues it finds when the patch is merged.  Please change the '-' to an alternate character so the plugin won't recognize the mentioned in passing issue reference.


https://gerrit.asterisk.org/#/c/7830/2/res/res_odbc.c
File res/res_odbc.c:

https://gerrit.asterisk.org/#/c/7830/2/res/res_odbc.c@1062
PS2, Line 1062: 	return AST_MODULE_RELOAD_SUCCESS;
This is the wrong identifier.  AST_MODULE_RELOAD_SUCCESS is defined to be returned by ast_module_reload() not this callback.  ast_module_reload() only cares about res == AST_MODULE_LOAD_SUCCESS and res != AST_MODULE_LOAD_SUCCESS when it calls the reload callback.  i.e., if the reload callback returns 0 on success or non-zero on error.



-- 
To view, visit https://gerrit.asterisk.org/7830
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f105f46d72553994e820679bfde3478a551b281
Gerrit-Change-Number: 7830
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 07 Jan 2018 02:10:04 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180106/07c5fbdd/attachment-0001.html>