[Asterisk-code-review] General: Avoid implicit conversion to char when changes valu... (asterisk[13])

Alexander Traud asteriskteam at digium.com
Sat Jan 6 02:34:02 CST 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7852 )

Change subject: General: Avoid implicit conversion to char when changes value to negative.
......................................................................


Patch Set 1:

res_http_websocket.c:311:52: error: pointer targets in passing argument 3 of ‘ast_careful_fwrite’ differ in signedness [-Werror=pointer-sign]

This is actually a bug in ast_careful_fwrite(.) because it forces a char* although it requires just a void*. No idea how to tackle this for Asterisk 13 without going for a type cast. Any ideas?


-- 
To view, visit https://gerrit.asterisk.org/7852
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cceaa88e147cbdf81a3a7beec5c1c20210fa41e
Gerrit-Change-Number: 7852
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sat, 06 Jan 2018 08:34:02 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180106/d7c9c651/attachment.html>


More information about the asterisk-code-review mailing list