[Asterisk-code-review] res pjsip endpoint identifier ip.c: Fix apply identify valid... (asterisk[master])

Corey Farrell asteriskteam at digium.com
Fri Jan 5 18:41:15 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7846 )

Change subject: res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7846/1/res/res_pjsip_endpoint_identifier_ip.c
File res/res_pjsip_endpoint_identifier_ip.c:

https://gerrit.asterisk.org/#/c/7846/1/res/res_pjsip_endpoint_identifier_ip.c@154
PS1, Line 154: 		ast_assert(c_value == NULL);
This will never assert (c_value will always be NULL so the condition passes).



-- 
To view, visit https://gerrit.asterisk.org/7846
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b519607263fe88e8ce964f526a45359fd362b6e
Gerrit-Change-Number: 7846
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sat, 06 Jan 2018 00:41:15 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180105/7b01cc93/attachment-0001.html>


More information about the asterisk-code-review mailing list