[Asterisk-code-review] stasis cache: Ignore subscription changes in caching topic e... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7788 )

Change subject: stasis_cache: Ignore subscription changes in caching_topic_exec.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7788/1/main/stasis_cache.c
File main/stasis_cache.c:

https://gerrit.asterisk.org/#/c/7788/1/main/stasis_cache.c@809
PS1, Line 809: 	msg_type = stasis_message_type(message);
             : 	if (stasis_subscription_change_type() == msg_type) {
             : 		return;
             : 	}
I don't think this is the correct solution here. This essentially blocks unsubscribes in the cache (not sure all the side effects of this).

(If I am wrong about this and this is a viable solution then I think it warrants a comment. Also it seems like some code can be removed from this function and maybe the file in general due to unsubscribe not being allowed in the cache?)

The leak does not appear to be here since if it is an unsubscribe the topic gets deref'ed at the end of this call. I think the ref count problem lies elsewhere?



-- 
To view, visit https://gerrit.asterisk.org/7788
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d502284730d243a217f91666616a27eba7995b0
Gerrit-Change-Number: 7788
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 03 Jan 2018 22:56:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180103/f7771c13/attachment.html>