[Asterisk-code-review] digium commits.py: Fix parsing crashes and add error feedback. (repotools[master])

George Joseph asteriskteam at digium.com
Wed Jan 3 07:32:39 CST 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7718 )

Change subject: digium_commits.py: Fix parsing crashes and add error feedback.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7718/2/parse_commit.py
File parse_commit.py:

https://gerrit.asterisk.org/#/c/7718/2/parse_commit.py@17
PS2, Line 17:     arg_parser.add_argument('-c', '--commit', help='The commit message')
            :     arg_parser.add_argument('-a', '--author', help='The author of the commit')
Add required=True to the options otherwise the there will be failures further in.



-- 
To view, visit https://gerrit.asterisk.org/7718
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd5c86d69d32bc95d93c0cc81851083410d082a4
Gerrit-Change-Number: 7718
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 03 Jan 2018 13:32:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180103/c004e72a/attachment.html>


More information about the asterisk-code-review mailing list