[Asterisk-code-review] pjproject: Add cache pools debugging option. (asterisk[15])

Richard Mudgett asteriskteam at digium.com
Wed Feb 28 11:39:43 CST 2018


Hello Jenkins2, George Joseph, Corey Farrell, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8287

to look at the new patch set (#4).

Change subject: pjproject: Add cache_pools debugging option.
......................................................................

pjproject: Add cache_pools debugging option.

The pool cache gets in the way of finding use after free errors of memory
pool contents.  Tools like valgrind and MALLOC_DEBUG don't know when a
pool is released because it gets put into the cache instead of being
freed.

* Added the "cache_pools" option to pjproject.conf.  Disabling the option
helps track down pool content mismanagement when using valgrind or
MALLOC_DEBUG.  The cache gets in the way of determining if the pool
contents are used after free and who freed it.

To disable the pool caching simply disable the cache_pools option in
pjproject.conf and restart Asterisk.

Sample pjproject.conf setting:
[startup]
cache_pools=no

* Made current users of the caching pool factory initialization and
destruction calls call common routines to create and destroy cached pools.

ASTERISK-27704

Change-Id: I64d5befbaeed2532f93aa027a51eb52347d2b828
---
M CHANGES
M configs/samples/pjproject.conf.sample
M include/asterisk/options.h
M include/asterisk/res_pjproject.h
M main/asterisk.c
M res/res_pjproject.c
M res/res_pjsip.c
M res/res_pjsip/location.c
M res/res_pjsip_history.c
M res/res_rtp_asterisk.c
10 files changed, 77 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/87/8287/4
-- 
To view, visit https://gerrit.asterisk.org/8287
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64d5befbaeed2532f93aa027a51eb52347d2b828
Gerrit-Change-Number: 8287
Gerrit-PatchSet: 4
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180228/1141146d/attachment-0001.html>


More information about the asterisk-code-review mailing list