[Asterisk-code-review] Add the ability to read the media file type from HTTP header... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8209 )

Change subject: Add the ability to read the media file type from HTTP header for playback
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/8209/4/include/asterisk/mod_format.h
File include/asterisk/mod_format.h:

https://gerrit.asterisk.org/#/c/8209/4/include/asterisk/mod_format.h@47
PS4, Line 47: 	char mime_types[80]; /*!< MIME Types related to the format (separated by | if more than one)*/
> Sorry for getting lost on this. I was totally stuck on another issue with A
ABI - Application Binary Interface
API - Application Programming Interface

Precompiled modules won't know about this new struct member so the existing struct members will be in the wrong place and effectively contain garbage.  Since this struct is normally allocated as a global variable in the format modules you cannot even add the new member to the end of the struct.  The new character array would effectively contain garbage.  This is why this patch can only go in the master branch.  In the master branch you can break interfaces because the code is not released for use yet.

As for repeatedly parsing the string, I don't think the extra CPU needed for parsing the string is much of a problem to consider alternate encodings.



-- 
To view, visit https://gerrit.asterisk.org/8209
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b14692a49b2c1ac67688f58757184122e92ba89
Gerrit-Change-Number: 8209
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Gaurav Khurana <gkhurana at godaddy.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 14:33:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180227/cbfbbbab/attachment.html>