[Asterisk-code-review] apps/app amd.c: Fixed total time and silence calculations (asterisk[13])

Sean Bright asteriskteam at digium.com
Sun Feb 25 11:57:01 CST 2018


Sean Bright has uploaded a new patch set (#2) to the change originally created by Michael Cargile. ( https://gerrit.asterisk.org/8389 )

Change subject: apps/app_amd.c: Fixed total time and silence calculations
......................................................................

apps/app_amd.c: Fixed total time and silence calculations

Between Asterisk 11 and Asterisk 13 there was a significant increase
in the number of AST_FRAME_NULL frames being processed by app_amd.c's
main loop. Each AST_FRAME_NULL frame was being counted as 100ms
towards the total time and silence. This may have been accurate
when app_amd.c was orginally added, but it is not in Asterisk 13.
As such the total analysis time and silence calculations were way
off effectively breaking app_amd.c

* Additional debug messages were added
* AST_FRAME_NULL are now ignored

ASTERISK-27610

Change-Id: I18aca01af98f87c1e168e6ae0d85c136d1df5ea9
---
M apps/app_amd.c
1 file changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/89/8389/2
-- 
To view, visit https://gerrit.asterisk.org/8389
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18aca01af98f87c1e168e6ae0d85c136d1df5ea9
Gerrit-Change-Number: 8389
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180225/e9e94824/attachment.html>


More information about the asterisk-code-review mailing list