[Asterisk-code-review] core: Fix handling of maximum length lines in config files. (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8382 )

Change subject: core: Fix handling of maximum length lines in config files.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Feel free to ignore my suggestion.

https://gerrit.asterisk.org/#/c/8382/2/main/config.c
File main/config.c:

https://gerrit.asterisk.org/#/c/8382/2/main/config.c@2200
PS2, Line 2200: 						if (strlen(buf) == sizeof(buf) - 1 && buf[sizeof(buf) - 2] != '\n') {
Bikeshedding, but how about:

 #define has_eol(x) \
  (strlen(x) != sizeof(x) - 1 || x[sizeof(x) - 2] == '\n')



-- 
To view, visit https://gerrit.asterisk.org/8382
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I80864a0d40d2e2d8cd79d72af52a8f0a3a99c015
Gerrit-Change-Number: 8382
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 17:53:34 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180223/73106841/attachment.html>