[Asterisk-code-review] core: Fix handling of maximum length lines in config files. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Fri Feb 23 11:12:32 CST 2018


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8380

to look at the new patch set (#3).

Change subject: core: Fix handling of maximum length lines in config files.
......................................................................

core: Fix handling of maximum length lines in config files.

When a line is the maximum length "\n" is found at sizeof(buf) - 2 since
the last character is actually the null terminator.  In addition if a
line was exactly 8190 plus a multiple of 8192 characters long the config
parser would skip the following line.

Additionally fix comment in voicemail.conf sample config.  It previously
stated that emailbody can only contain up to 512 characters which is
always wrong.  The buffer is normally 8192 characters unless LOW_MEMORY
is enabled then it is 512 characters.  The updated comment states that
the line can be up to 8190 or 510 characters since the line feed and
NULL terminator each use a character.

ASTERISK-26688 #close

Change-Id: I80864a0d40d2e2d8cd79d72af52a8f0a3a99c015
---
M configs/samples/voicemail.conf.sample
M main/config.c
2 files changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/80/8380/3
-- 
To view, visit https://gerrit.asterisk.org/8380
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80864a0d40d2e2d8cd79d72af52a8f0a3a99c015
Gerrit-Change-Number: 8380
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180223/1b978403/attachment-0001.html>


More information about the asterisk-code-review mailing list