[Asterisk-code-review] pjproject: Improve MALLOC DEBUG checking. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8288 )

Change subject: pjproject: Improve MALLOC_DEBUG checking.
......................................................................


Patch Set 1: Code-Review-1

> > Instead of doing this as a pjproject patch, can we do it in
 > > res_pjsip/load_pjsip instead?  Maybe use their pool_dbg?
 > 
 > If this can be accomplished at runtime I think that would be
 > better.  This would allow use of an option like cache_media_frames
 > to disable pool caching for use with valgrind (without needing
 > MALLOC_DEBUG).

Another option might be to simply clone the cached pool factory as a non-cached version and submit it upstream.  Then add a pjsip.conf/system option to use the cached or non-cached memory pool factory.


-- 
To view, visit https://gerrit.asterisk.org/8288
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64d5befbaeed2532f93aa027a51eb52347d2b828
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 15:53:22 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180223/e952f8e0/attachment-0001.html>